Use "Rotate Image" operation in the Live Viewer #2016
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.right_click_menu = self.live_viewer.image.vb.menu | ||
| rotate_menu = self.right_click_menu.addMenu(translate("ViewBox", "Rotate Image")) | ||
| rotate_angles_group = QActionGroup(self) | ||
| rotate_0 = QAction(translate("ViewBox", "0" + u'\N{DEGREE SIGN}'), rotate_angles_group) |
There was a problem hiding this comment.
Given that we are not using translation anywhere else, I don't think we should start here. (Whether we should make everything translatable is an interesting question).
Also, in python3 it should be fine using the degree symbol in a string.
rotate_0 = QAction(translate("0°"), rotate_angles_group)
There was a problem hiding this comment.
Fair enough, I used it as that's how its structured in the ViewBox module so kept it consistent with that. If we start getting a non-english user base then that would be a good question to ask!
|
Superseded by #2021 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2003
Description
The images in the Live Viewer can now be rotated by 90, 180, or 270 degrees via a right-click menu option. Once selected, this is apply to all images shown in the Live Viewer so the option only needs to be chosen once.
This functionality uses the existing framework in
mantidimaging.core.operations.rotate_stack.rotate_stack.pysuccessfully suggesting that other operations could be implemented in the Live Viewer in the future.Testing
make checkruns successfully but unit tests will be added in the future. Currently no testing exists for the Live Viewer window.Acceptance Criteria
Load images into the Live Viewer and check that the data is rotated as expected.
Documentation
Will be added in release notes